Skip to content

chore(image): add example how to create an image with uefi disabled #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025

Conversation

Fyusel
Copy link
Contributor

@Fyusel Fyusel commented Aug 15, 2025

Description

relates to #923

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel Fyusel requested a review from a team as a code owner August 15, 2025 09:52
@Fyusel Fyusel added the do-not-merge Do not merge this right now label Aug 15, 2025
@Fyusel
Copy link
Contributor Author

Fyusel commented Aug 15, 2025

Check with Iaas Team because this would be a breaking change.

@Fyusel Fyusel force-pushed the change-image-uefi-parameter-to-false branch 2 times, most recently from 0eb4cb5 to 4d43c0a Compare August 18, 2025 09:08
@Fyusel Fyusel removed the do-not-merge Do not merge this right now label Aug 18, 2025
@Fyusel Fyusel changed the title chore(image): change uefi default value to false chore(image): add example how to create an image with uefi disabled Aug 18, 2025
@Fyusel
Copy link
Contributor Author

Fyusel commented Aug 18, 2025

Outcome: We only add an example how to create an image with uefi=false

@Fyusel Fyusel force-pushed the change-image-uefi-parameter-to-false branch from 4d43c0a to fa4a952 Compare August 20, 2025 06:31
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/image/create 47.31% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/image/create/create.go 47.31% (ø) 167 79 88

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@Fyusel Fyusel merged commit eb7c321 into main Aug 20, 2025
5 checks passed
@Fyusel Fyusel deleted the change-image-uefi-parameter-to-false branch August 20, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants